Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@DylanDylann Updated

If you add archivedReportsIDSet to getSecondaryTransactionThreadActions, also remove isChatReportArchived in the same PR (same for getSecondaryReportActions function). Don't add archivedReportsIDSet now and remove isChatReportArchived later, do it all now or leave it all for later.

--> A suggestion to avoid creating a big PR: try not to touch too many functions at once. Let's fully complete function A before moving on to the next one. With this approach, it'll be easier to manage and we'll be less likely to miss anything

Updated

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

🚧 @blimpich has triggered a test Expensify/App build. You can view the workflow run here.

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #79832.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-835b40acb31-79c0e20-6eee618cad6da24774a8c7a4d862d658bfc3f054/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-835b40a-79c0e20-ffffd16bc5e6fe53301983f6b02d39b14d5b19b9/index.html

Web 🕸️
https://79832.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

🚀 Deployed to staging by https://github.com/blimpich in version: 9.4.2-0 🚀

Bundle Size Analysis (Sentry):

• Android
• iOS

🤖 Help site review: no documentation changes required.

I reviewed the changes in this PR against the help articles under App/docs/articles and did not create a docs PR, because this change is an internal code refactor with no user-facing impact.

Why no docs are needed:

• The PR removes an Onyx.connect() call for ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS and migrates callers to the hook-based useArchivedReportsIDSet.
• It refactors several function signatures into parameter objects and renames a hook file (useArchivedReportsIdSet.ts → useArchivedReportsIDSet.ts).
• The existing behavior — archived reports being filtered out of report selection, edit, and "Move expenses" flows — is preserved, not changed. The PR author notes: "Everything should work as before. Sanity testing should be enough."
• No src/languages/* strings, UI labels, feature names, tabs, settings, or buttons were added or modified.

Help articles document user-facing product behavior, and this PR introduces no new or changed behavior, so there is nothing to update on the help site.

If you believe a specific user-facing behavior did change here that should be documented, reply with @MelvinBot <details> and point me to it, and I'll draft the corresponding docs PR.

@ShridharGoel @DylanDylann @JmillsExpensify Could you please confirm if we should test this PR on Android and iOS apps? Step 7 of this Test is fail for apps, user is redirected to Home page. Is this WAD?

@ShridharGoel The flow has already been changed. Could you please revise this test step accordingly?

Updated

🚀 Deployed to staging by https://github.com/blimpich in version: 9.4.4-1 🚀

Bundle Size Analysis (Sentry):

• Android
• iOS

Help site review: no docs changes required

I reviewed the changes in this PR against the help site articles under App/docs/articles and no documentation updates are required.

Why: This is a pure internal refactor with no user-facing behavior change. Specifically, it:

• Removes the Onyx.connect() call for ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS and replaces it with hook-based data via useArchivedReportsIDSet.
• Threads archivedReportsIDSet into IOU/report selection, edit, and search-selection logic so archived chats are filtered consistently (an existing behavior, now sourced differently).
• Converts positional function arguments to object params and renames the hook file casing (useArchivedReportsIdSet → useArchivedReportsIDSet).

The PR introduces no new feature, UI element, tab, setting, button, or label — and the author's own QA note confirms "Everything should work as before." Help site articles document user-facing product behavior, which is unchanged here, so there is nothing to add or update.

Since no docs changes are needed, I did not create a draft help site PR. If you believe a specific article should be updated, let me know which one and I'll take another look.

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.4-3 🚀